ClusterLogHandler cannot accept all log records

[wtsergo]

ClusterLogHandler cannot accept all log records.
e.g. in \Amp\Http\Server\Driver\Internal\AbstractHttpDriver::handleInternalServerError
you have

$this->logger->error(
  "...",
  [
    ...
    'method' => $request,
    ...
  ]
);

Then ClusterLogHandler cannot send such error context via channel because $request have closures in nested properties.
Maybe need to add some kind of filter there? e.g. skip unserializable items?

I can contribute on fix for that.
Just let me know how do you think such problem should be handled.

Thanks.

[trowski]

Hi @wtsergo. I'm finally coming back around to updating this library. Sorry for the long delay.

It looks like we may have eliminated the specific logger entry you're referring to, but the fundamental issue remains. Sometimes a logger context could contain unserializable entries.

Did you have any suggestions on how to handle this? My first thought is to offer an optional wrapper which strips context and extra from log records after processing the message, replacing any placeholders.

[bmsergo]

Hello @trowski,

I just serialize ['context']['exception'] into string before send over channel.
Yours seems to be more flexible.