Skip to content

[Performance] Memoize username#7736

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-username-5748205486080182555
Draft

[Performance] Memoize username#7736
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-username-5748205486080182555

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented Jun 6, 2026

WHY are these changes introduced?

The username function performs environment lookups, os.userInfo() calls, and potential execa calls which are expensive. Since the username is static during the CLI execution, memoizing the result improves efficiency.

WHAT is this pull request doing?

This PR implements memoization for the username function in packages/cli-kit/src/public/node/os.ts by caching the resulting Promise in a module-level variable.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 5748205486080182555 started by @gonzaloriestra

@gonzaloriestra
[Performance] Memoize username
07828fb 
The `username` function performs environment lookups, `os.userInfo()` calls, and potential `execa` calls which are expensive. Since the username is static during the CLI execution, memoizing the result improves efficiency.

This PR implements memoization for the `username` function in `packages/cli-kit/src/public/node/os.ts` by caching the resulting Promise in a module-level variable.

Expected performance impact:
Reduces redundant system calls and environment lookups. While the absolute time saved per call is small (milliseconds), it adds up in high-frequency paths or when called multiple times during command initialization and analytics reporting.
@google-labs-jules
Copy link
Copy Markdown

google-labs-jules Bot commented Jun 6, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gonzaloriestra