fix(ng-dev): redact URL credentials from child process logs and errors#3760
Open
josephperrott wants to merge 2 commits into
Open
fix(ng-dev): redact URL credentials from child process logs and errors#3760josephperrott wants to merge 2 commits into
josephperrott wants to merge 2 commits into
Conversation
josephperrott
added
the
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces URL credential sanitization for child process command logging and error messages to prevent leaking sensitive tokens, and adds corresponding unit tests. The review feedback correctly identifies a bug in the sanitization regular expression that causes false positives on URLs with @ in their path (such as scoped npm packages) and provides a code suggestion to fix it.
josephperrott
force-pushed
the
fix/sec-childprocess-sanitize-03587b8b
branch
2 times, most recently
from
02edc40 to
2bb04d0
Compare
josephperrott
added
action: merge
josephperrott
force-pushed
the
fix/sec-childprocess-sanitize-03587b8b
branch
from
2bb04d0 to
10ffcf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 03587b8b. Redacts URL credentials from child process execution logs and thrown errors to prevent token exposure.