fix(ng-dev): sanitize credentials and tokens from GitClient logs and errors#3762
Open
josephperrott wants to merge 3 commits into
Open
fix(ng-dev): sanitize credentials and tokens from GitClient logs and errors#3762josephperrott wants to merge 3 commits into
josephperrott wants to merge 3 commits into
Conversation
josephperrott
added
the
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the GitClient and AuthenticatedGitClient to sanitize HTTP credentials and process errors in console outputs, and introduces a new test suite to verify these changes. The feedback recommends improving cross-platform compatibility in the tests by replacing hardcoded /tmp paths with os.tmpdir(), and requests the removal of leftover debugging console.log statements.
josephperrott
added
action: merge
josephperrott
force-pushed
the
fix/sec-git-client-sanitize-58c20eaf
branch
from
2432d52 to
f6636ea
Compare
josephperrott
force-pushed
the
fix/sec-git-client-sanitize-58c20eaf
branch
from
f6636ea to
fccae4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 58c20eaf. Redacts credentials and GitHub tokens from GitClient and AuthenticatedGitClient logs and error messages/stacks.