[bug](iceberg) fix can't get migrated Iceberg tables format type#64134
Open
zhangstar333 wants to merge 2 commits into
Open
[bug](iceberg) fix can't get migrated Iceberg tables format type#64134zhangstar333 wants to merge 2 commits into
zhangstar333 wants to merge 2 commits into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
I found one blocking correctness issue in the new fallback path. The PR goal is clear and the main property-order change is small, but the fallback must not silently continue with Parquet when manifest/data-file inspection fails, because that can reproduce the same ORC-as-Parquet corruption path and can also make write/delete planning choose an incorrect format.
Critical checkpoint conclusions:
- Goal/test: The change targets migrated Iceberg tables without write-format/write.format.default, but no regression/unit/manual test evidence is provided for ORC migrated tables or inference failure paths.
- Scope: The final code is focused on getFileFormat, but the fallback changes error semantics.
- Concurrency/lifecycle/config/compatibility: No new shared mutable state, lifecycle management, config, or storage-format compatibility issue found.
- Parallel paths: getFileFormat is used by scan, insert, delete, merge, compression, and commit metadata paths; the silent Parquet fallback affects all of them.
- Error handling: Blocking issue below; inference failure is converted to Parquet instead of failing with context.
- Data correctness: The fallback can select the wrong physical file format after a real planning/IO/auth failure.
- Performance/observability: planFiles may add extra planning IO for tables without format properties; logs are present, but they are not enough if execution continues with the wrong format.
- Tests/results: No test changes or result updates in the PR.
User focus: No additional user-provided review focus was specified.
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 29458 ms |
Contributor
TPC-DS: Total hot run time: 169699 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The migrated Iceberg table properties don't have "write-format" or "write.format.default".
so doris use the default type of parquet as the table format. but it's actual a ORC type.
now add more check to infer the table format type.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)