[Wasm RyuJit] Match how other targets consume initblk fill values#129062
Open
AndyAyersMS wants to merge 1 commit into
Open
[Wasm RyuJit] Match how other targets consume initblk fill values#129062AndyAyersMS wants to merge 1 commit into
AndyAyersMS wants to merge 1 commit into
Conversation
genConsumeOperands(blkOp) routed the contained GT_INIT_VAL through genConsumeRegs and tripped its OperIsLeaf assert. Replace the call with explicit consume of dest and the unwrapped src, as other targets do. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
@dotnet/wasm-contrib PTAL Fixes some pri0 asserts (case 2 here: #128234 (comment)) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WASM RyuJIT codegen for GT_STORE_BLK so that when the initblk fill value is wrapped in a contained GT_INIT_VAL, codegen consumes the wrapped value (gtGetOp1()) instead of routing the GT_INIT_VAL wrapper through genConsumeRegs (which asserts on non-leaf contained nodes in codegenlinear.cpp).
Changes:
- Replace
genConsumeOperands(blkOp)with explicit consumption ofdestand an unwrappedsrcwhensrcis a containedGT_INIT_VAL. - Add an assertion documenting the invariant that
GT_INIT_VALshould be contained in this path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
genConsumeOperands(blkOp) routed the contained GT_INIT_VAL through genConsumeRegs and tripped its OperIsLeaf assert. Replace the call with explicit consume of dest and the unwrapped src, as other targets do.