fix: dark mode contrast#1402
Open
scissorsneedfoodtoo wants to merge 5 commits into
Open
Conversation
raisedadead
approved these changes
Jun 5, 2026
ahmaxed
reviewed
Jun 5, 2026
| --gray45: #858591; | ||
| --gray15: #d0d0d5; | ||
| --gray10: #dfdfe2; | ||
| --gray05: #eeeef0; |
Member
There was a problem hiding this comment.
Is there a reason we are changing thi?
Contributor
Author
There was a problem hiding this comment.
I was going through and noticed that this is different than what we havein the main repo.
But thinking back I do remember you saying that there's a reason for this a while back. I can go ahead and change it back now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)This PR includes a handful of fixes for colors in dark mode.
It sets the color for text and links for post cards and pages to the secondary color variable, which is now set to
#f5f6f7to match what we have in the main repo. It also fixes the colors for the under header section on author and tag pages so text and social link buttons are visible, and adds colors to the footer section for better separation, similar to what we have on Learn.There are some photos below for reference.