v6: polyfill localStorage in test setup for Node 24 + jsdom#4334
Merged
Conversation
Node 24 defines `window` via jsdom but leaves `localStorage` undefined, causing `StorageAPI` to throw on construction. Add a minimal in-memory polyfill to `setup-files.ts` in both `@graphiql/react` and `@graphiql/toolkit` (adding a setup file + vitest config wiring for the latter).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 24 ships with a
jsdomversion that defineswindowbut leaveslocalStorageundefined, which causesStorageAPIto throw on construction in unit tests. This adds a minimal in-memorylocalStoragepolyfill to the vitest setup files for@graphiql/reactand@graphiql/toolkit, gated ontypeof localStorage === 'undefined'so it has no effect in environments where the real API is present. The toolkit package previously had no setup file, so this also wires one into itsvitest.config.mts.