Skip to content

gh-150942: Speed up frame local item collection #151002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omkar-334 wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −6
Open

gh-150942: Speed up frame local item collection #151002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52f8cf0
Speed up frame local item collection
omkar-334 Jun 6, 2026
8b20fe3
add patch contributor name
omkar-334 Jun 6, 2026
680bbd9
Merge branch 'main' into speed-up-frame-locals-items
omkar-334 Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-06-06-08-20-00.gh-issue-150942.Jk9pQr.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Speed up frame local variable item collection by appending result pairs to the
output list without an extra reference-count round-trip (using the internal
reference-stealing list append helper). Patch by Omkar Kabde.
9 changes: 3 additions & 6 deletions Objects/frameobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "pycore_function.h" // _PyFunction_FromConstructor()
#include "pycore_genobject.h" // _PyGen_GetGeneratorFromFrame()
#include "pycore_interpframe.h" // _PyFrame_GetLocalsArray()
#include "pycore_list.h" // _PyList_AppendTakeRef()
#include "pycore_modsupport.h" // _PyArg_CheckPositional()
#include "pycore_object.h" // _PyObject_GC_UNTRACK()
#include "pycore_opcode_metadata.h" // _PyOpcode_Caches
Expand Down Expand Up @@ -636,9 +637,7 @@ framelocalsproxy_items(PyObject *self, PyObject *Py_UNUSED(ignored))
goto error;
}

int rc = PyList_Append(items, pair);
Py_DECREF(pair);
if (rc < 0) {
if (_PyList_AppendTakeRef((PyListObject *)items, pair) < 0) {
goto error;
}
}
Expand All @@ -655,9 +654,7 @@ framelocalsproxy_items(PyObject *self, PyObject *Py_UNUSED(ignored))
goto error;
}

int rc = PyList_Append(items, pair);
Py_DECREF(pair);
if (rc < 0) {
if (_PyList_AppendTakeRef((PyListObject *)items, pair) < 0) {
goto error;
}
}
Expand Down
Loading