gh-151001: fix coverage-lcov target for lcov v2.x#151008
Open
Aniketsy wants to merge 2 commits into
Open
Conversation
Aniketsy
requested review from
AA-Turner,
emmatyping,
erlend-aasland and
itamaro
as code owners
Aniketsy
changed the title
skirpichev
reviewed
Jun 6, 2026
| --directory $(abs_builddir) \ | ||
| --base-directory $(realpath $(abs_builddir)) \ | ||
| --path $(realpath $(abs_srcdir)) \ | ||
| --ignore-errors negative \ |
Contributor
Author
There was a problem hiding this comment.
geninfo: ERROR: Unexpected negative count '-1' for branch 1 of /mnt/d/cpython/cpython/Modules/getpath.c:944.
Perhaps you need to compile with '-fprofile-update=atomic
(use "geninfo --ignore-errors negative ..." to bypass this error)
make: *** [Makefile:1070: coverage-lcov] Error 1
i added after getting error ..
Contributor
Author
There was a problem hiding this comment.
hmm, but it looks off, as in diff it looks like --ignore-errors negative \ is added as replacement, should add this below one line, Do you have any suggestion for me ? thanks
| @lcov $(COVERAGE_LCOV_OPTIONS) --capture \ | ||
| --directory $(abs_builddir) \ | ||
| --base-directory $(realpath $(abs_builddir)) \ | ||
| --path $(realpath $(abs_srcdir)) \ |
Member
There was a problem hiding this comment.
Why this argument was needed before?
Contributor
Author
There was a problem hiding this comment.
--path was added in 2013 (commit 49e52f9) with --base-directory, but the commit message doesn't explain its specific purpose but further it was changed, and now means "Strip PATH from tracefile when applying diff"
(.venv) aniket@DESKTOP-074O80J:/mnt/d/cpython/cpython$ lcov --help | grep path
-b, --base-directory DIR Use DIR as base directory for relative paths
--path PATH Strip PATH from tracefile when applying diff
--list-full-path Print full path during a list operation
Member
|
Please add news. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #151001